Skip to content

Initial POC for perfspect integration#959

Merged
mlim19 merged 5 commits into
masterfrom
enable_perfspect_html
May 9, 2025
Merged

Initial POC for perfspect integration#959
mlim19 merged 5 commits into
masterfrom
enable_perfspect_html

Conversation

@mlim19

@mlim19 mlim19 commented Apr 14, 2025

Copy link
Copy Markdown
Contributor

This is the new feature supporting HW metrics in gprofiler that is collected via Perfspect tool.

Description

The feature is requested at #956. The gprofiler metadata section includes the HW metrics for both text and the HTML content as blob generated by Perfspect tool.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots

Checklist:

  • I have read the CONTRIBUTING document.
  • I have updated the relevant documentation.
  • I have added tests for new logic.

@dkorlovs dkorlovs force-pushed the enable_perfspect_html branch 6 times, most recently from 5e50899 to 17ca105 Compare April 14, 2025 21:25
mlim19 added 3 commits April 30, 2025 09:22
Signed-off-by: Min Lim <min.yeol.lim@intel.com>
Signed-off-by: Min Lim <min.yeol.lim@intel.com>
Signed-off-by: Min Lim <min.yeol.lim@intel.com>
@dkorlovs dkorlovs force-pushed the enable_perfspect_html branch from 511f624 to ddbb9c8 Compare April 30, 2025 16:28
@mlim19 mlim19 requested a review from dkorlovs May 2, 2025 17:14
Comment thread gprofiler/hw_metrics.py Outdated
Comment thread gprofiler/hw_metrics.py Outdated
Comment thread gprofiler/hw_metrics.py Outdated
Comment thread gprofiler/hw_metrics.py
Comment thread gprofiler/hw_metrics.py Outdated
Comment thread gprofiler/hw_metrics.py Outdated
Comment thread gprofiler/main.py Outdated
Comment thread gprofiler/main.py Outdated
Comment thread gprofiler/main.py Outdated
Comment thread gprofiler/merge.py

@dkorlovs dkorlovs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@mlim19 mlim19 merged commit 5920804 into master May 9, 2025
76 of 78 checks passed
@mlim19 mlim19 deleted the enable_perfspect_html branch May 9, 2025 16:04
@ambud

ambud commented May 9, 2025

Copy link
Copy Markdown

R+

prashantbytesyntax pushed a commit to pinterest/gprofiler that referenced this pull request Jul 23, 2025
* Initial POC for perfspect integration

Signed-off-by: Min Lim <min.yeol.lim@intel.com>

* Fix python linter issues

Signed-off-by: Min Lim <min.yeol.lim@intel.com>

* Remove the existing files when collection starts

Signed-off-by: Min Lim <min.yeol.lim@intel.com>

* Revised based on review comments

Signed-off-by: Min Lim <min.yeol.lim@intel.com>

---------

Signed-off-by: Min Lim <min.yeol.lim@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants